MediaWiki talk:Common.css

Please remove the background on `mw-warning-with-logexcerpt.mw-warning-with-logexcerpt.mw-warning-with-logexcerpt, div.mw-lag-warn-high, div.mw-cascadeprotectedwarning, div#mw-protect-cascadeon {` or replace it with a CSS variable that can adapt to dark mode. I am not sure why this is styled as an error, when the message itself is a warning and has a triangle - so the color is confusing so I personally would vote for removing it or moving it to MediaWiki:Timeless.css etc..

I have a global script for forcing dark mode on all pages, and when dark mode gets enabled on the editor, this will break. It would be good to fix this before that happens! Thanks in advance!

Example: https://en.wikipedia.org/w/index.php?title=Template:Sidebar_with_collapsible_lists&action=edit (with dark mode global script). 🐸 Jdlrobson (talk) 04:46, 31 May 2024 (UTC)Reply

This is styled as an error because that's the importance we assign it, not the arbitrary importance assigned to it by the WMF at a date long after our modification was added. Stjn had a similar block in the ru.wp CSS which he modified to the CSS at ru:MediaWiki:Common.css#L-111, which I just haven't had a chance to test. Izno (talk) 18:52, 31 May 2024 (UTC)Reply

@Izno If the goal is to style this as an error, it would be better to use the Codex design token to ensure accessibility with links etc and get the night mode equivalent for consistency:

  background-color: var(--background-color-error-subtle);

While I don't think it looks great, having a warning icon with a red color, if this style needs to be retained as is, without the CSS variable, you need to also add a rule for text color - like what I'm doing in User:Jdlrobson/common.css. Without that, the interface will become unusable in dark mode.

/* https://en.wikipedia.org/wiki/MediaWiki_talk:Common.css#Applying_a_style_for_the_Vector_2022 */
.mw-warning-with-logexcerpt.mw-warning-with-logexcerpt.mw-warning-with-logexcerpt, div.mw-lag-warn-high, div.mw-cascadeprotectedwarning, div#mw-protect-cascadeon {
  color: black;
}

🐸 Jdlrobson (talk) 15:54, 8 June 2024 (UTC)Reply

  Done using the error-subtle design token, and keeping the existing color as fallback since the variable doesn't seem to be defined at all on Vector legacy which I use. * Pppery * _{it has begun...} 01:35, 18 June 2024 (UTC)Reply

@Pppery just following up here after feedback on https://www.mediawiki.org/w/index.php?title=Reading/Web/Accessibility_for_reading/Reporting/en.wikipedia.org#Special:Contributions_dark_mode_error . Looks like this wasn't done for warnings. That should be using --background-color-warning-subtle. Should I create a new edit request or can we do it as part of this one? Jon (WMF) (talk) 16:53, 15 July 2024 (UTC)Reply

That's due to a different block of CSS than the one referred to in the initial comment here, so I likely never noticed it. Now fixed. * Pppery * _{it has begun...} 23:15, 15 July 2024 (UTC)Reply

I am using Vector 2022, light color mode. On page MediaWiki:Group-templateeditor.css, the following CSS rule is defined to make the background of wikitext editor light pink  , when the page is protected:

.mw-textarea-protected,
.mw-textarea-protected + .ui-resizable .ace_content,
.mw-textarea-protected + .CodeMirror {
  background-color: hsl(0, 100%, 94%);
}

It works for CodeMirror (selector .mw-textarea-protected + .CodeMirror), i.e. with   syntax highlighting enabled, but doesn't work when it is disabled   (selector .mw-textarea-protected). Instead, the background color is white. For example, I as a template editor see it when editing Template:Notfixed.

This is caused by <textarea id="wpTextbox1"> having background-color: transparent; in its inline style attribute in combination with <div id="wpTextbox0" ... style="... background-color: rgb(255, 255, 255); ...">.

Tag <textarea id="wpTextbox1"> in this case also has CSS class ext-WikiEditor-realtimepreview-textbox which comes from mw:Extension:WikiEditor (found via GitHub search). Unfortunately, I wasn't able to figure out where inline styles of wpTextbox0 and wpTextbox1 come from.

Workaround is to add a similar rule to your common.css, but with !important:

.mw-textarea-protected, .mw-textarea-protected + .ui-resizable .ace_content, .mw-textarea-protected + .CodeMirror {
	background-color: hsl(0, 100%, 94%) !important;
}

example of using this workaround. —⁠andrybak (talk) 11:33, 20 July 2024 (UTC)Reply

I don't have the same issue when editing the example template: both with and without syntaxhighlighting I have a pink background. Izno (talk) 16:24, 20 July 2024 (UTC)Reply

I think I figured out where background-color: transparent; is coming from. It is from gadget MediaWiki:Gadget-DotsSyntaxHighlighter.js. To enable the gadget:

Preferences → Gadgets → Editing →   ^(S) Syntax highlighter: Alternative to the default coloring of wiki syntax in the edit box (works best in Firefox and works almost all of the time in Chrome and Opera)

Without the gadget, the issue goes away. The style is set at line 640 of non-minified code.

I guess I'll try reporting the issue to mw:User talk:Remember the dot/Syntax highlighter.js. —⁠andrybak (talk) 16:54, 20 July 2024 (UTC)Reply

Please see mw:User talk:Remember the dot/Syntax highlighter.js#Inline styles interfere with enwiki's CSS. —⁠andrybak (talk) 17:23, 20 July 2024 (UTC)Reply

Hey @Iznothe latest changes do not seem to be compatible with the VisualEditor wikitext editor unfortunately.

https://phabricator.wikimedia.org/F56601761 🐸 Jdlrobson (talk) 18:35, 22 July 2024 (UTC)Reply

I think this was an issue my side that I've now resolved. I had a color black that was applying there for a related rule.

Possibly color: white should be added as well to avoid conflicts with other scripts/gadgets? 🐸 Jdlrobson (talk) 18:41, 22 July 2024 (UTC)Reply

I'm happy to take someone getting it further, but as I said at VPT that inspired the adjustment, it will probably take some elaboration. There is at least one outstanding incompatibility with the change, that being syntax highlighting on normal wikitext pages, but there's still a bug for that in Phab that needs resolution. Izno (talk) 19:05, 22 July 2024 (UTC)Reply

I would appreciate the ability to use the .texhtml class with the semantic <var> tag. Either of the following two changes would do the trick:

Remsense ‥ 诉 11:01, 16 August 2024 (UTC)Reply

texhtml will at some point be TemplateStyled, so I'd honestly appreciate not spreading it around to arbitrary elements. :) Izno (talk) 14:18, 16 August 2024 (UTC)Reply

Good to know! I would like that too, so I'm happy to be patient. Remsense ‥ 诉 14:19, 16 August 2024 (UTC)Reply

It would already be so if not for phab:T200704. I made a really sad workaround at Template:Math-link but haven't spent the time rolling it out because of just how hackish it needs to be. Izno (talk) 19:20, 16 August 2024 (UTC)Reply

I've been working on getting ready to stop loading MediaWiki:Mobile.css and MediaWiki:Mobile.js on English Wikipedia, and make MediaWiki:Common.css and MediaWiki:Common.js load on mobile. There have been a few edits to MediaWiki:Common.css and MediaWiki:Print.css to ready that, but now I'm going to be making a few changes which might get someone discussing sternly at me, so I'm leaving a section here preemptively in case we need to discuss certain cutoffs and such. I'll leave other implementation notes at the working page. Izno (talk) 18:21, 6 September 2024 (UTC)Reply

What's the motivation for this? Asking purely out of curiosity :) –Novem Linguae (talk) 19:18, 6 September 2024 (UTC)Reply

phab:T248416#9678769 makes the external motivation clear I think (i.e. at some point we won't have a choice because Mobile.css/js are technical debt), but for my part I've just been annoyed at the duplication that was present at MediaWiki:Mobile.css and which is now at MediaWiki:Minerva.css and the fact that the Minerva skin isn't consistent with every other skin. Izno (talk) 20:14, 6 September 2024 (UTC)Reply

Page watchers may be interested in Wikipedia talk:Manual of Style § Mobile skin and block quotations. Please feel free to participate there. Izno (talk) 04:07, 7 September 2024 (UTC)Reply