Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading Docs and Error Messages #335

Open
anonhostpi opened this issue Mar 24, 2024 · 5 comments
Open

Misleading Docs and Error Messages #335

anonhostpi opened this issue Mar 24, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request platform:openwrt This issue is related to the OpenWrt platform

Comments

@anonhostpi
Copy link

Describe the bug
This line of the install script appears to be misleading:

echo -e "${FontRed}error: Only Linux distributions using systemd are supported.${FontSuffix}"

as it conflicts with this statement of the readme:

- Openwrt

To Reproduce
Attempt to use install.sh on OpenWRT

Expected behavior
Inform the user that OpenWRT is supported, but must be extracted or built manually.

Screenshots
If applicable, add screenshots to help explain your problem.

Info (please complete the following information):

  • Server OS: OpenWrt 23.05.2
  • Server Arch: x86/64
  • Nginx UI Version: v2.0.0-beta.18-patch.2
  • Your Browser: N/A

Additional context
OpenWRT does not include systemd

@anonhostpi anonhostpi added the bug Something isn't working label Mar 24, 2024
@anonhostpi
Copy link
Author

anonhostpi commented Mar 24, 2024

Also I made a tutorial on how to get this to work on OpenWRT: https://www.reddit.com/r/linux/comments/1bmcsz0/howto_nginxui_on_openwrt_without_building/

@Hintay
Copy link
Collaborator

Hintay commented Mar 24, 2024

Thank you for your tutorial. I'd like to inform you that you can directly download the pre-build executable binary for your architecture from the release page.

The current installation script does not support Linux distributions without systemd. I understand the inconvenience this may cause, and I assure you that I am working on updating the script to support OpenWRT in the next version.

@Hintay Hintay added enhancement New feature or request and removed bug Something isn't working labels Mar 24, 2024
@anonhostpi
Copy link
Author

anonhostpi commented Mar 25, 2024

The issue is more of a lack of specificity. The install script makes it look like nginx-ui isn't supported at all, instead of just not being supported by the installer.

@anonhostpi
Copy link
Author

anonhostpi commented Mar 25, 2024

If you were curious about the technicals, OpenWRT uses init scripts instead of systemd service files

The services defined in /etc/init.d/ are literally shell scripts that use rc.common to bootstrap them and make them behave like services

The service command functions as an alias/wrapper for /etc/init.d/<service> <command> (service <service> <command>)

@Hintay
Copy link
Collaborator

Hintay commented Nov 5, 2024

We've updated the install script to clarify the error message. We’re also considering compiling Nginx UI into an ipk package for OpenWRT.

@Hintay Hintay added the platform:openwrt This issue is related to the OpenWrt platform label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request platform:openwrt This issue is related to the OpenWrt platform
2 participants