Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform SatelliteImage class into an optional dictionary attribute in Raster #532

Open
rhugonnet opened this issue Mar 29, 2024 · 1 comment
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request

Comments

@rhugonnet
Copy link
Contributor

rhugonnet commented Mar 29, 2024

After more thinking, the organization Raster / SatelliteImage / DEM does not make so much sense anymore: some DEMs can be purely modelled, and are not necessarily from an acquisition.

In the end, the SatelliteImage class is essentially just an extra metadata parser on top of Raster, which could live as simply an __init__ option of the Raster class and store the metadata in an optional dictionary attribute such as the tags attribute for raster metadata.

In short, we could:

  • Remove the SatelliteImage class,
  • Add the functionalities as a parse_sensor_metadata option to Raster, true by default, which stores all in a .sensor dictionary attribute,
  • Subclass DEM from Raster.
@adehecq
Copy link
Member

adehecq commented Apr 8, 2024

Good idea !!

@rhugonnet rhugonnet added enhancement Feature improvement or request architecture Need to re-organize or re-structure something labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Need to re-organize or re-structure something enhancement Feature improvement or request
2 participants