-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new audit: bfcache eligibility #13960
Comments
I think there were two big things:
|
I assume all these reasons have their own translated strings in CDT frontend. We should probably take the time to figure out how to reuse this stuff across protocol frontends. Was it documented anywhere why we can't do i18n over the protocol? #13961 shows how duplicating strings looks. |
If we need to test an actual navigation, then we could just attach this to navigation mode and only make it applicable in a user flow step that triggers a navigation via back/forward buttons. We could also cancel #13904 and add another "pass" that exercises the bfcache stuff. |
Unsure if it was linked earlier, but you may also be interested in the BFCache Not Restored Reasons list maintained by Yuzu and the BFCache team. |
we'll do the about:blank (or chrome://terms ??) -> back in a gatherer that runs last, but also will exclude this in user flows (for now). in the future, perhaps user flows will have a flag, or the gatherer will at least run (by default) but w/o the navigation so that it can collect whatever back navigations the user scripts. |
docs tracked in #14586 |
Provide a basic description of the audit
Expose reasons why a page isn't a candidate for bfcache
https://web.dev/bfcache/
Basically exposing the same data that's in the BFCache Devtools panel:
How would the audit appear in the report?
When failing it'd list all the failing reasons with nice strings.
The reasons come from the protocol. This event provides them:
Page.BackForwardCacheNotRestoredExplanationTree
(There are a lot of reasons. 123 of them!)
I didn't follow exactly how devtools triggers the right kind of navigation/reload that will get this event. But... presumably something.It appears the panel does:
Page.navigate('chrome://terms')
Page.FrameNavigated
Page.navigateToHistoryEntry
Page.BackForwardCacheNotRestoredExplanationTree
eventHow is this audit different from existing ones?
@brendankenny did an unload handler one. I recall him saying we werent ready for more bfcachey things... but don't recall specifics.
What % of developers/pages will this impact?
All pages can benefit from bfcache.
How is the new audit making a better web for end users?
Faster navigations. (close to zero TTFBs)
What is the resourcing situation?
LH core team.
Any other links or documentation that we should check out?
The text was updated successfully, but these errors were encountered: