-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break and stop the pagination if we have the results #152
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
81a40ab
to
591e495
Compare
I signed it! |
Thank you for contribution. I think that we mitigated spike in the list requests in newly released GCS connector 1.9.15 (see issue #151), but this will be worthwhile improvement anyway, please allow us some time to review it. |
I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Thanks for the quick response. I'll try to fix the tests somewhere today. |
Right now the while loop will continue to fetch results while we already have the object. Which can be very expensive when you're looking if a directory exists, and it will fetch all the pages.
Thanks @medb |
Hi Googlers,
I would like to suggest the following optimization. Right now the while loop will continue to fetch results while we already have the max results. For example, will become very inefficient when you're looking if a directory exists, and it will fetch all the pages.
This caused our cluster to do 10th of thousands of requests per second, which became quite expensive.
Regards, Fokko