Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwindToViewController not working in iOS 15 #724

Open
rued opened this issue Sep 28, 2021 · 3 comments
Open

unwindToViewController not working in iOS 15 #724

rued opened this issue Sep 28, 2021 · 3 comments

Comments

@rued
Copy link

rued commented Sep 28, 2021

What did you do?

I have VC1 -> VC2 -> VC3
I use VC3.hero.unwindToViewController(VC1) to unwind.

What did you expect to happen?

With iOS 14 and earlier, this has been working fine, I see a smooth transition from VC3 -> VC1

What happened instead?

After upgrading to iOS 15, the unwind DO happen, but the animation is from VC3 -> VC3, and when done an instant switch to VC1.
debugger reports: 'Unbalanced calls to begin/end appearance transitions for VC3'

General Information

  • Hero Version: 1.6.1

  • iOS Version(s): iOS 15

  • Swift Version: Swift 5.5

  • Devices/Simulators: iPhone 12 Pro

  • Reproducible in Examples? (Yes/No): No

Demo Project

None

@rued
Copy link
Author

rued commented Sep 29, 2021

I might add that I'm not using Navigation controllers.

VC2 & VC3 are opened using:

let controller = XXXViewController() // isHeroEnabled = true is set in viewDidLoad
controller.modalPresentationStyle = .fullScreen
controller.delegate = self
controller.datasource = self
controller.heroModalAnimationType = .selectBy(presenting:.slide(direction: .left), dismissing:.slide(direction: .right))
self.present(controller, animated: true)

@JoeMatt JoeMatt modified the milestones: 1.6.1, 1.7.0 Sep 30, 2021
@varunpm1
Copy link

I have seen one more issue on iOS 15 with similar steps. I see a black screen when dismissing and I have attached example project as well - #721

@LeonBiters
Copy link

I also encountered the same problem. How did you solve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment