Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataColumn API for breaks in Legend/Axis #417

Open
AndreiKingsley opened this issue Jul 30, 2024 · 2 comments
Open

Add DataColumn API for breaks in Legend/Axis #417

AndreiKingsley opened this issue Jul 30, 2024 · 2 comments
Labels
dataframe An issue/PR related to dataframe enhancement New feature or request good first issue Good for newcomers lets-plot API and implementation for lets-plot

Comments

@AndreiKingsley
Copy link
Collaborator

AndreiKingsley commented Jul 30, 2024

Add new breaks (an analogue for all existing function) with DatColumn argument for passing breaks for axis and legend:

fun breaks(breaks: DataColumn<DomainType>, format: String? = null)

https://github.com/Kotlin/kandy/blob/main/kandy-lets-plot/src/main/kotlin/org/jetbrains/kotlinx/kandy/letsplot/scales/guide/model/LetsPlotAxis.kt
https://github.com/Kotlin/kandy/blob/main/kandy-lets-plot/src/main/kotlin/org/jetbrains/kotlinx/kandy/letsplot/scales/guide/model/LetsPlotLegend.kt
A common case:

legends {
   breaks(column.distinct())
}
@AndreiKingsley AndreiKingsley added enhancement New feature or request good first issue Good for newcomers lets-plot API and implementation for lets-plot dataframe An issue/PR related to dataframe labels Jul 30, 2024
@devcrocod
Copy link
Collaborator

Please provide detailed instructions on how to complete this task

@AndreiKingsley
Copy link
Collaborator Author

Add breaks(DataColumn) function with the same logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataframe An issue/PR related to dataframe enhancement New feature or request good first issue Good for newcomers lets-plot API and implementation for lets-plot
2 participants