async: Tolerate early disconnects #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The typing was added anticipating [145], and can be removed if that's not going anywhere; more important was documenting the variable (even though it's internal), and making sure it's only accessed in ways that tolerate double disconnects (eg. due to a network disconnect racing against a user disconnect, or because something disconnects just to be sure). Closes: Mic92#157 [145]: https://github.com/Mic92/python-mpd2/pull/145/files
mweinelt
approved these changes
Jan 14, 2021
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing was added anticipating 145, and can be removed if that's
not going anywhere; more important was documenting the variable (even
though it's internal), and making sure it's only accessed in ways that
tolerate double disconnects (eg. due to a network disconnect racing
against a user disconnect, or because something disconnects just to be
sure).
Closes: #157