Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat-req] add all missing commands from mpc, minor improvement #168

Closed
ozone89 opened this issue Mar 5, 2021 · 2 comments
Closed

[feat-req] add all missing commands from mpc, minor improvement #168

ozone89 opened this issue Mar 5, 2021 · 2 comments

Comments

@ozone89
Copy link

ozone89 commented Mar 5, 2021

First thing first, thank you for the hard work you're putting into this project :D

As per title, it'd be nice to have the command set on par with mpc

List can be found here https://helpmanual.io/help/mpc/ or via mpc help

In particular, would be nice to have at least cdprev and toggle, as it would simplify some coding

as an example, I have managed to implement the former as

if float(client.status()['elapsed']) < 5:
        client.previous()
else:
        client.play(client.status()['song'])

also, little improvement would be to have the value of the fields returned as the proper type

@Mic92
Copy link
Owner

Mic92 commented Mar 6, 2021

Are those also in the mpd protocol?

@Mic92
Copy link
Owner

Mic92 commented Apr 22, 2021

I prefer to not make library more complex than necessary.

@Mic92 Mic92 closed this as completed Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants