Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when user account is expired and unable to login #423

Closed
dasunhegoda opened this issue May 16, 2024 · 5 comments · Fixed by #549
Closed

Improve error message when user account is expired and unable to login #423

dasunhegoda opened this issue May 16, 2024 · 5 comments · Fixed by #549
Assignees

Comments

@dasunhegoda
Copy link
Contributor

dasunhegoda commented May 16, 2024

The error message needs to be improved for a user, when logging in with an expired user account in openspp test instance

for example, a simple error message in login screen: Your account has already expired , please contact admin for more information and support

Video link attached for reference:
https://drive.google.com/file/d/1iKisuLzcc1w9AOQlWIubFeNjZ_eFQeyI/view?usp=sharing

Investigation - Red

  • This functionality is developed by OCA so I think the error can be improve by either OpenSPP or OpenG2P guys
@anthonymarkQA
Copy link

anthonymarkQA commented Sep 25, 2024

Findings: Returned to dev
Tested in runboat instance http://openspp-openspp-modules-deploy-549-edb41b4feea3.runboatk8.newlogic-demo.com/web#cids=1&menu_id=224&action=336

Upon logging in with an expired user. i still am able to login and there is no access error message
image

image

@reichie020212
Copy link
Member

@anthonymarkQA I removed the Test 2 because it seems that there is a change in the odoo's core module code regarding the Access Error that's why it is not showing anymore but rather it just disappear the menus that the user doesn't have permission to view.

for the Upon logging in with an expired user. i still am able to login, this is expected since what expired only is the role of the user not the actual user.

Returning this to QA

@anthonymarkQA
Copy link

anthonymarkQA commented Oct 4, 2024

Findings: Returned to DEV

for example. as system admin, if my account has an expired system admin role, upon login, the features i used to have access before becomes hidden. even though the reason is my access is just expired, this would confuse the user if there are issues with openspp.

a message prompt upon login would be great that informs the user that the system admin role has expired, contact support for more information. and this message prompt behavior can have two options:

  1. Modal appears only once.
  2. Modal appears every login and a checkbox [ ]do not show this again , when ticked, will not display the message anymore

Note: if there are more than one roles expired. it will display in the modal at the same time.

To be reviewed with team @dasunhegoda

@reichie020212
Copy link
Member

return this ticket to QA based on what was discussed in the standup. Thanks.

@anthonymarkQA
Copy link

Findings: QA Passed

Setting this ticket to QA passed as agreed during standup. fixing the odoo error upon login alone is enough for now for this ticket.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants