Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the UI and the demo generator of farmer registry demo module #567

Open
reichie020212 opened this issue Sep 4, 2024 · 3 comments · May be fixed by #598
Open

Split the UI and the demo generator of farmer registry demo module #567

reichie020212 opened this issue Sep 4, 2024 · 3 comments · May be fixed by #598
Assignees

Comments

@reichie020212
Copy link
Member

reichie020212 commented Sep 4, 2024

Currently there is no general module for farmer registry base that can be used in production generally, to accomodate this, let's do the following

  • Create a new module named OpenSPP Farmer Registry Default UI.
  • Move the codes of UI of the module OpenSPP Farmer Registry Demo to OpenSPP Farmer Registry Default UI
  • Retain the generation of demo data in OpenSPP Farmer Registry Demo
  • OpenSPP Farmer Registry Demo module should add in its manifest the OpenSPP Farmer Registry Default UI module
@reichie020212 reichie020212 linked a pull request Sep 18, 2024 that will close this issue
@reichie020212 reichie020212 linked a pull request Sep 18, 2024 that will close this issue
@anthonymarkQA
Copy link

Findings: Returned to dev

Issues Found:
Installing the new module: OpenSPP Farmer Registry Default UI seems to not install the farmer specific tabs for the group.
image

Installing farmer registry Demo should ONLY add the Generate sample data from configuration and nothing else- Fail (it also adds the farmer registry default Ui like the tabs for the farmer etc..)
image

icon of OpenSPP Farmer Registry Default UI is broken
image

@anthonymarkQA anthonymarkQA self-assigned this Sep 18, 2024
@anthonymarkQA
Copy link

anthonymarkQA commented Sep 19, 2024

Hi @celinenilla , as @reichie020212 investigated this ticket and concluded thatFarmer_registry_demomodule comes with additional tabs for the farm group, these additional tabs were created under farmer_registry_demo intended to show specific clients what farmer registry could offer more than just the default tabs it has. thats why installing it adds not just the generate sample data button but also additional tabs for the farmer.

to achieve your goal that only generate sample data button will be added when installing "farmer_registry_demo" we can request red to comment out the additional tabs in the farmer_registry_demo module's codes to hide them(additional tabs) for now.

this would also mean i will update the testcases as i am under the assumption that these additional tabs come as default for farmer registry offering.

let us know what you think

Image

@celinenilla
Copy link

sounds good, the default ui can do without these three tabs. let's also hide them in the demo module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants