[JetChat] Add glance widget for JetChat App #1424 #1425
Conversation
# Conflicts: # Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
| @@ -67,5 +67,8 @@ | |||
| <string name="more_options">More options</string> | |||
| <string name="touch_and_hold_to_record">Touch and hold to record</string> | |||
| <string name="record_message">Record voice message</string> | |||
| <string name="widget_loading_error">Cannot load Widget</string> | |||
There was a problem hiding this comment.
| <string name="widget_loading_error">Cannot load Widget</string> | |
| <string name="widget_loading_error">Problem loading the widget</string> |
| val appWidgetManager = AppWidgetManager.getInstance(context) | ||
| val myProvider = ComponentName(context, WidgetReceiver::class.java) | ||
|
|
||
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { |
There was a problem hiding this comment.
Instead of showing the error only when user clicks the button, can we prevent showing the drawer item at all?
Maybe you can abstract the method to something like widgetAddingIsSupported() that uses the SDK check and uses the isRequestPinAppWidgetSupported and check for that before showing the UI.
Jetchat/app/src/main/java/com/example/compose/jetchat/components/JetchatDrawer.kt
Show resolved
Hide resolved
| @@ -64,6 +64,58 @@ private val initialMessages = listOf( | |||
| "8:03 PM" | |||
| ) | |||
| ) | |||
| val unreadMessages = listOf( | |||
There was a problem hiding this comment.
I suggest instead of adding bunch of copy pastes, to use something like the initialMessages and filter it for the unread messages. Maybe filter the ones not from the current author?
val unreadMessages = initialMessages.filter { it.author != "me" }
If you don't have enough messages, you can add more (meaningful-ish) messages to the initialMessages
| <?xml version="1.0" encoding="utf-8"?> | ||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="#ffffff" | ||
| android:gravity="center"> | ||
|
|
||
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:textColor="@color/black30" | ||
| android:text="@string/widget_loading_error" /> | ||
| </RelativeLayout> |
| android:background="#ffffff" | ||
| android:gravity="center"> | ||
|
|
||
| <TextView | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:textColor="@color/black30" |
There was a problem hiding this comment.
Try not to use direct colors, but use the tokens from the Theme
| style = TextStyle(fontWeight = FontWeight.Bold) | ||
| ) | ||
| Text( | ||
| text = message.content, |
There was a problem hiding this comment.
I'm not a fan of us not being able to format the text in any form. Showing the unformatted font looks unstyled :(
| title = LocalContext.current.getString(R.string.app_name_unreads), | ||
| ) | ||
| }) { | ||
| val unreadMessage = unreadMessages |
There was a problem hiding this comment.
unreadMessages should be hoisted and passed into MessagesWidget from provideGlance.
Usually in a Glance Widget you will pass to your widget a repository and the widget can access flows in the composable function. Even though this is fakeData we should try to keep as much as possible to this pattern.
| Column(modifier = GlanceModifier.clickable(actionStartActivity<NavActivity>()).fillMaxWidth()) { | ||
| Text( | ||
| text = message.author, | ||
| style = TextStyle(fontWeight = FontWeight.Bold) |
There was a problem hiding this comment.
add color = GlanceTheme.colors.onSurface to the TextStyle. This will make the colors update when you switch to dark mode.
| ) | ||
| Text( | ||
| text = message.content, | ||
| style = TextStyle(fontWeight = FontWeight.Normal) |
There was a problem hiding this comment.
add color = GlanceTheme.colors.onSurface to the TextStyle. This will make the colors update when you switch to dark mode.
| import androidx.glance.appwidget.GlanceAppWidget | ||
| import androidx.glance.appwidget.GlanceAppWidgetReceiver | ||
|
|
||
| class WidgetReceiver : GlanceAppWidgetReceiver() { |
There was a problem hiding this comment.
You have a widget error layout but do not use it. Consider referencing it here with the errorUiLayout property or implementing onCompositionError
|
Thanks for the review @secondsun and @mlykotom will work on these over the weekend and will re-request a review. |
Added an Unreads widget for the JetChat app using Glance. Also has a option to add widget to home screen on the app.
Glance.Widget.Recording.webm
Fixes #1424