Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils.social phonesFromText issues with slashes #437

Open
bwundo opened this issue Aug 1, 2019 · 2 comments
Open

utils.social phonesFromText issues with slashes #437

bwundo opened this issue Aug 1, 2019 · 2 comments
Labels
t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@bwundo
Copy link

bwundo commented Aug 1, 2019

On pages with phone numbers formatted like this:
0175/234234, 0160/345345 and +49151/456456

It just adds 234234, 345345 and 456456 to the result set "phonesUncertain".
@mnmkng
Copy link
Member

mnmkng commented Aug 21, 2019

cc @jancurn
@jancurn
Copy link
Member

jancurn commented Aug 21, 2019

Indeed, slashes are currently not recognized. PRs welcome.

On a related note, phone number detection using regular expressions is rather poor, to make it work properly, we'd need to use some AI extractor.
@mtrunkat mtrunkat added the t-tooling Issues with this label are in the ownership of the tooling team. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
4 participants
@mtrunkat @jancurn @mnmkng @bwundo