Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the code of ns.html from XHTML+RDFa (XHTML 4) to HTML+RDFa (HTML 5) #429

Closed
wants to merge 1 commit into from
Closed

Changed the code of ns.html from XHTML+RDFa (XHTML 4) to HTML+RDFa (HTML 5) #429

wants to merge 1 commit into from

Conversation

BalrajDhakad
Copy link

@BalrajDhakad BalrajDhakad commented Apr 4, 2024 •
edited by TimidRobot
Loading

Fixes

Description

I have changed the whole code restructured it and made to be written in html5, also I have organized the code with proper indentation and spacing.

As the ns.html file is written in HTML 4 to convert it to HTML 5 I have made some changes which are I have change:

  1. Doctype Declaration

Changed the doctype declaration from:

Use code with caution.

To:

Use code with caution.
This specifies that the document is written in HTML5.

  1. Changed the xml:lang attribute on the html element to lang.
  2. Removed unnecessary namespaces declared on the html element.
  3. Added the vocab attribute to the html element to define the base vocabulary used for RDFa annotations.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.
@BalrajDhakad
changed the code of ns.html from html 4 to html 5
cae9701 
I have changed the whole code restructured it and made to be written in html5, also I have organized the code with proper indentation and spacing.
@BalrajDhakad BalrajDhakad requested review from a team as code owners April 4, 2024 06:43
@BalrajDhakad BalrajDhakad requested review from TimidRobot and possumbilities and removed request for a team April 4, 2024 06:43
@mzeinstra
Copy link

Please test that the RDF of the current pages matches exact to the RDF to the new HTML. I haven't tested this myself.

There are plenty of pages that refer to this page, any change here would mean changing the meaning of other pages. I know for example that millions of pages on europeana.eu include references to the namespace.
@BalrajDhakad
Copy link
Author

It was already RDFa, the main issue was to convert HTML 4 to HTML 5 @mzeinstra
@mzeinstra
Copy link

I am not saying that there is anything wrong with the pull request. I think it would be a good idea to test that the RDF output remains the same and that a change in the HTML did not lead to an unforeseen change in the RDF.
TimidRobot
TimidRobot requested changes Apr 4, 2024
View reviewed changes
Copy link
Member

@TimidRobot TimidRobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore 2 space indent (instead of change to 4 space indent)
@TimidRobot
Copy link
Member

TimidRobot commented Apr 4, 2024 •
edited
Loading

Use code with caution.

This doesn't inspire confidence that this submission satisfies the DCO

⛔️ status: discarded Will not be worked on

@TimidRobot TimidRobot closed this Apr 4, 2024
@TimidRobot TimidRobot added the ⛔️ status: discarded Will not be worked on label Apr 4, 2024
@TimidRobot TimidRobot self-assigned this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ status: discarded Will not be worked on
3 participants
@BalrajDhakad @mzeinstra @TimidRobot