Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to pass configuration to shaka #34

Closed
krychu90 opened this issue Sep 9, 2020 · 2 comments
Closed

Ability to pass configuration to shaka #34

krychu90 opened this issue Sep 9, 2020 · 2 comments
Labels
1.0.x version 1.0.x feature Feature request

Comments

@krychu90
Copy link

krychu90 commented Sep 9, 2020

Hello,
there is no ability to pass configuration to shaka-player except drm.
Can you improve your plugin that will be possible to pass other configuration to { shaka: {} } property?

Regards
@davidjamesherzog
Copy link
Owner

davidjamesherzog commented Sep 28, 2020 •
edited
Loading

So, sounds like you want to be able to pass any of these values and not just the drm one that it currently supports?

https://shaka-player-demo.appspot.com/docs/api/tutorial-config.html
@krychu90
Copy link
Author

So, sounds like you want to be able to pass any of these values and not just the drm one that it currently supports?

https://shaka-player-demo.appspot.com/docs/api/tutorial-config.html

Yes
@davidjamesherzog davidjamesherzog mentioned this issue Oct 23, 2020
Merged
@davidjamesherzog davidjamesherzog added 1.0.x version 1.0.x feature Feature request labels Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.x version 1.0.x feature Feature request
2 participants
@krychu90 @davidjamesherzog