Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Support formatting sql files with deno fmt #25024

Open
M4RC3L05 opened this issue Aug 13, 2024 · 2 comments · May be fixed by #26750
Open

Feat: Support formatting sql files with deno fmt #25024

M4RC3L05 opened this issue Aug 13, 2024 · 2 comments · May be fixed by #26750
Labels
deno fmt Related to the "deno fmt" subcommand or dprint suggestion suggestions for new features (yet to be agreed)

Comments

@M4RC3L05
Copy link

As the title says, have deno fmt support sql files.
Would this be something to be considered?
@lucacasonato lucacasonato added suggestion suggestions for new features (yet to be agreed) deno fmt Related to the "deno fmt" subcommand or dprint labels Aug 22, 2024
@M4RC3L05
Copy link
Author

M4RC3L05 commented Nov 4, 2024

Just noticed https://github.com/dprint/dprint-plugin-sql, would it be possible to add this to deno?
@bartlomieju
Copy link
Member

Yes, we could potentially use https://github.com/shssoichiro/sqlformat-rs directly (which the plugin uses under the hood) to format SQL files. If a PR is opened to integrate it with deno fmt we can discuss it during the team meeting if we will merge it. I think if it started with requirement on --unstable-sql flag there's a good chance that would happen.
@M4RC3L05 M4RC3L05 linked a pull request Nov 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deno fmt Related to the "deno fmt" subcommand or dprint suggestion suggestions for new features (yet to be agreed)
3 participants
@lucacasonato @bartlomieju @M4RC3L05