Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(messaging, ios): allow system to display button for in-app notification settings #13484

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(messaging, ios): allow system to display button for in-app notification settings #13484

wants to merge 3 commits into from

Conversation

StanleyCocos
Copy link
Contributor

@StanleyCocos StanleyCocos commented Oct 10, 2024 •
edited by SelaseKay
Loading

Description

I found that there is no option to set a button to display the app settings in the notification settings when registering for push notifications. I hope to add this feature.

resolves #13688

Specifically, the UNAuthorizationOptions.UNAuthorizationOptionProvidesAppNotificationSettings provided by iOS is missing.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.
@Lyokone
Copy link
Contributor

Lyokone commented Oct 29, 2024

Hey 👋 Thanks a lot for the PR, and sorry for the late review, it looks really good.
Lyokone
Lyokone previously approved these changes Oct 29, 2024
View reviewed changes
@StanleyCocos
Copy link
Contributor Author

Thank you Already submitted
@StanleyCocos
Copy link
Contributor Author

@Lyokone
Thank you
What else do I need to do to merge this request?
@StanleyCocos StanleyCocos mentioned this pull request Nov 5, 2024
Open
@Lyokone
Copy link
Contributor

Lyokone commented Nov 5, 2024

Hello @StanleyCocos, a lot of CI are currently red, you would need to apply proper formatting to your PR (melos run format-ci) then check the different actions to get it merged
@StanleyCocos
Copy link
Contributor Author

Thank you.
I will revise and follow up in time.
@StanleyCocos
Copy link
Contributor Author

@Lyokone
Hello, are you still continuing with the review?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@StanleyCocos @Lyokone