Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add auth #103

Open
GunniBusch opened this issue May 23, 2024 · 4 comments
Open

FEATURE: Add auth #103

GunniBusch opened this issue May 23, 2024 · 4 comments
Milestone

Comments

@GunniBusch
Copy link

Hi, would it be possible to add some kind of auth like email/password and or oauth?
Then we could host this also at a remote location.

@helloteemo
Copy link

The built-in auth is complicated. Some authentication information needs to be stored within the system, and persistence needs to be considered

Shouldn't Glance be viewed as an all-around system; as an adhesive between multiple systems, it is more in line with the business positioning?

If it should be used as an adhesive, can an interface be defined to connect to an existing authentication service in the form of an interface to achieve auth

Such as

type AuthConfig struct {
	// RedirectURL is the URL to redirect the user to when they need to log in.
	LoginRedirectURL string
	// IsAuthenticatedURL is the URL to check if the user is authenticated.
	IsAuthenticatedURL string
}

type Auth interface {
	// IsAuthenticated returns true if the user is authenticated.
	IsAuthenticated(macAddress string) (bool, error)
	// JumpToLogin redirects the user to the login page.
	JumpToLogin(macAddress string) error
}
@flamestro
Copy link

I am not sure if glance needs auth tbh, as most of the information is public anyway.
You could argue that the collection of the given information in one pot makes it kinda data sensitive. But thats up to the maintainers.

Anyways, in the meantime you can use this to get oauth up and running without glance implementing auth:
https://github.com/oauth2-proxy/oauth2-proxy

@svilenmarkov
Copy link
Member

Hey, thanks for the suggestion!

Unfortunately I don't plan on adding auth for the time being, though you can easily overcome this limitation by using something like Authelia or Authentik.

@svilenmarkov svilenmarkov added this to the Backlog milestone May 25, 2024
@adrian-goe
Copy link

A BasicAuth option should be enough right? At least, a first initial option.
I'm not familiar with go. So I can't help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants