-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Add auth #103
Comments
The built-in auth is complicated. Some authentication information needs to be stored within the system, and persistence needs to be considered Shouldn't Glance be viewed as an all-around system; as an adhesive between multiple systems, it is more in line with the business positioning? If it should be used as an adhesive, can an interface be defined to connect to an existing authentication service in the form of an interface to achieve auth Such as type AuthConfig struct {
// RedirectURL is the URL to redirect the user to when they need to log in.
LoginRedirectURL string
// IsAuthenticatedURL is the URL to check if the user is authenticated.
IsAuthenticatedURL string
}
type Auth interface {
// IsAuthenticated returns true if the user is authenticated.
IsAuthenticated(macAddress string) (bool, error)
// JumpToLogin redirects the user to the login page.
JumpToLogin(macAddress string) error
} |
I am not sure if glance needs auth tbh, as most of the information is public anyway. Anyways, in the meantime you can use this to get oauth up and running without glance implementing auth: |
A BasicAuth option should be enough right? At least, a first initial option. |
Hi, would it be possible to add some kind of auth like email/password and or oauth?
Then we could host this also at a remote location.
The text was updated successfully, but these errors were encountered: