core(tsc): add type checking to sentry usage #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Sep 7, 2018
lighthouse-core/lib/sentry.js
Outdated
| {pattern: /No.*node with given id/, rate: 0.01}, | ||
| {pattern: /Could not load stylesheet/, rate: 0.1}, | ||
| {pattern: /No.*resource with given/, rate: 0.1}, | ||
| {pattern: /No.*node with given id/, rate: 0.1}, |
There was a problem hiding this comment.
we could drop these completely? Also do they fire multiple times per run? We could fire once per audit instead (does sentry support adding a count payload and have a decent aggregation view of them?)
6 tasks
paulirish
reviewed
Sep 8, 2018
lighthouse-core/lib/sentry.js
Outdated
| // Ignore expected errors | ||
| if (err.expected) return empty; | ||
| // Sample known errors that occur at a high frequency | ||
| const sampledErrorMatch = SAMPLED_ERRORS.find(sample => sample.pattern.test(err.message)); |
There was a problem hiding this comment.
can we keep this block?
along with something like this above:
const SAMPLED_ERRORS = [
// Error code based sampling
// e.g.: {pattern: /No.*node with given id/, rate: 0.01},
];
|
type stuff and fonts look good! |
paulirish
approved these changes
Sep 8, 2018
paulirish
approved these changes
Sep 8, 2018
| const sentryDelegate = Object.assign({}, sentryApi); | ||
| sentryDelegate.init = function init(opts) { | ||
| const sentryDelegate = { | ||
| init, |
There was a problem hiding this comment.
lol the hoist. a lil fancy for my tastes, but ok.. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
long-standing TODO.
Also fixes #5971