core(gather-runner): include error status codes in pageLoadError #6051
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a pageLoadError for 400/500 http status codes. Fixes #4082; depends on #6014 (see dcb468a for actual diff).
Example Report
Good:
runtimeError
Less good:
http-status-code
SEO audit (new SEO audit: HTTP status code #3311). That audit successfully marks the page as 404ing (or whatever), but all the other audits around it are marked asError!
(since no gatherers in that pass return an artifact), so it's pretty much lost in the noiseref #5881