Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Shariff without jQuery #372

Open
markymcfly opened this issue Jan 14, 2020 · 2 comments
Open

Feature Request: Shariff without jQuery #372

markymcfly opened this issue Jan 14, 2020 · 2 comments

Comments

@markymcfly
Copy link

It would be great if this plugin worked without jQuery!

@onli
Copy link

onli commented Sep 20, 2023

I built that at https://github.com/onli/shariff-plus - shariff-plus is a maintained fork of shariff, which I forked again to remove jQuery. Currently, my code also removes the dialog that defined the plus in shariff-plus, making it just a patched, modernized version of shariff (but I might restore that dialog to make it easier for shariff-plus to incorporate my changes).

Is this project interested in getting a similar modernization for shariff itself? Having done the work already once, I could repeat it and send in a PR. Or the project could just copy the code.

My approach also eliminates all the old modules and babel stuff, as it is not needed in modern browsers. The idea would be to use something like rollup.js instead. That would make maintaining this project a lot easier, especially if you also get rid of the LESS files. But that's your decision.

@liayn
Copy link
Contributor

liayn commented Sep 20, 2023

@onli Thanks for speaking up here.
I, as maintainer of the TYPO3 integration, would be interested of course, but it's up to Heise (@pmb0) to decide that.
I'm actually surprised that we saw a release recently again.
If the decision is negative, I will most probably adjust our integration to use a shariff-plus variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants