Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html default #72

Closed
jonschlinkert opened this issue Oct 27, 2014 · 7 comments
Closed

html default #72

jonschlinkert opened this issue Oct 27, 2014 · 7 comments

Comments

@jonschlinkert
Copy link
Owner

I think we should consider setting html: true by default. Partially to be consistent with other markdown libraries, but also because I think this is what most users expect. But before we change it maybe we can get feedback from users, I might be wrong.

@puzrin
Copy link
Contributor

puzrin commented Oct 27, 2014

I have no principal objection, if majority of users really need html to be enabled. Intention was to keep output safe by default, but we should not push users with my fiction ideas.

@jonschlinkert
Copy link
Owner Author

Intention was to keep output safe by default

ah, yes that's true. lol and same for me, I don't know what most users want. maybe we can keep this open a little longer to see if anyone cares. if a few days go by with no comments we can just close if that's okay with you

@jonathanong
Copy link

i wish there were a "safe html" option that removes stuff like onclick handlers and <script> tags. if that could be implemented, i think that should be default, though i don't see an easy way of doing that. maybe a client-side plugin.

@puzrin
Copy link
Contributor

puzrin commented Oct 29, 2014

That's can't be implemented safe and easy way. So it doesn't worth to implement at all. If you need html sanitization - external package should be used. Or, if you need safe output immediately - disable html and write necessary syntax extentions via plugins

@jonschlinkert
Copy link
Owner Author

hey @jonathanong! so basically are you saying that your preference would that if html is turned on by default it should only be if for "safe html"? e.g. would that be a "deal killer"?

@jonathanong
Copy link

yes. if you had unsafe html as default, some developer who didn't read the docs will start complaining about security issues. better to avoid that :)

@jonschlinkert
Copy link
Owner Author

you make a great point... and this issue is officially resolved lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants