This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Panel: Implement classes option #8350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes extra tests no longer required
| pageFixedToolbar: "ui-panel-fixed-toolbar", | ||
| pageContentPrefix: "ui-panel-page-content", /* Used for wrapper and fixed toolbars position, display and open classes. */ | ||
| animate: "ui-panel-animate" | ||
| "ui-panel": "ui-panel-closed" |
There was a problem hiding this comment.
@arschmitz can correct me if I'm wrong, but I don't believe ui-panel-closed is supposed to be a value, but rather a key. The value of a class key is supposed to be a set of style-related classes, IINM.
There was a problem hiding this comment.
I suppose then there is not even a need of classes option here.
|
|
||
| // if animating, add the class to do so | ||
| this._addClass( this.element, "ui-panel ui-panel-closed", this._getPanelClasses() ); |
There was a problem hiding this comment.
no need to pass this.element its the default, this._addClass( "ui-panel ui-panel-closed", this._getPanelClasses() );
|
this looks good once you make the 2 changes |
|
@arschmitz Done! |
|
👍 |
apsdehal
added a commit
that referenced
this pull request
Feb 25, 2016
apsdehal
added a commit
to apsdehal/jquery-mobile
that referenced
this pull request
Mar 26, 2016
arschmitz
pushed a commit
to arschmitz/jquery-mobile
that referenced
this pull request
Jul 4, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7709