Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Encoders and Decoders? #796

Open
lhazlewood opened this issue Aug 9, 2023 · 0 comments
Open

Consolidate Encoders and Decoders? #796

lhazlewood opened this issue Aug 9, 2023 · 0 comments
Milestone

Comments

@lhazlewood
Copy link
Contributor

Perhaps introduce Codec<I, O> extends Encoder<I, O>, Decoder<O, I> for a symmetric codec that does both - for Base64 and Base64URL, it's just simpler to have a component that does both and can be referenced in multiple places. Plus it's annoying to try to remember which static utility class (Encoders or Decoders) you should reference during coding or tests, when just calling Codecs would always work.

Configuration methods (encoder(Encoder), decoder(Decoder), etc) should not be changed - APIs should accept only the minimum of what they require to function.

This would allow also deleting of all private/protected and package-protected classes/methods in the api module's io.jsonwebtoken.io package (7+ classes or so)

@lhazlewood lhazlewood added this to the 0.12.0 milestone Aug 9, 2023
@lhazlewood lhazlewood modified the milestones: 0.12.0, 1.0 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant