Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxScaleFactor @4x and more does not work #1134

Closed
EgorSaffrezzi opened this issue Jan 18, 2024 · 3 comments
Closed

maxScaleFactor @4x and more does not work #1134

EgorSaffrezzi opened this issue Jan 18, 2024 · 3 comments

Comments

@EgorSaffrezzi
Copy link

maxScaleFactor does not work and does not generate tiles for suffix greater than @3x. But its correct work for @2x and @3x.
Is there anything I might be missing or am I doing wrong?

DOCS:

maxScaleFactor
Maximum scale factor to allow in raster tile and static maps requests (e.g. @3x suffix). Also see maxSize below. Default value is 3, maximum 9.
image

My config file:
image
image
image

@acalcutt
Copy link
Collaborator

From the code it looks like if you set maxScaleFactor that it should go beyond 3x. I see you are setting it so not sure why that wouldn't work.

You can see here that it makes a render pool for each scale factor
https://github.com/maptiler/tileserver-gl/blob/master/src/serve_rendered.js#L1230-L1242

And it is supposed to accept up to 9 scale factor (and default to 3)
https://github.com/maptiler/tileserver-gl/blob/master/src/serve_rendered.js#L525

@acalcutt
Copy link
Collaborator

acalcutt commented Jan 19, 2024

Looking at the example config vs your config, I think maybe you put 'maxScaleFactor' in the wrong place.

If you look at the example at https://maptiler-tileserver.readthedocs.io/en/latest/config.html#configuration-file , 'maxScaleFactor' is under options, but it looks to me like you have it outside options in your screenshot above.

@EgorSaffrezzi
Copy link
Author

@acalcutt You are best. Thanks man !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants