-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unhandled exception when pmtiles is used and GeoJSON is requested #1187
Comments
I think that check should probably be removed, since the data from pmtiles getZxy function is already ungzipped I removed similar checks in the area you mentioned, but that one must have been missed. a PR to remove that check is welcome. |
Just wondering, do you have an example pmtiles geojson file I can test with? The PR looks good, I just realized geojson pmtiles isn't something I have tested before. |
Nevermind, I forgot this isn't a geojson formatted pmtiles, but a pbf pmtiles in geojson format. I can test with what I have. |
Thank for the PR, it has been merged. I will try to make a new release when I get home later tonight. |
Fixed by #1188 |
In
serve_data.js
an exception is triggered becauseisGzipped
is undefined: https://github.com/maptiler/tileserver-gl/blob/master/src/serve_data.js#L73 whenpmtiles
is used as data source and GeoJSON is requested.Solution is to either add a check for Gzip magic bytes as per https://github.com/maptiler/tileserver-gl/blob/master/src/serve_data.js#L120 or remove the check entirely.
The text was updated successfully, but these errors were encountered: