Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MotionSubjects for operator testing #208

Open
1 of 3 tasks
appsforartists opened this issue Apr 25, 2017 · 0 comments
Open
1 of 3 tasks

Use MotionSubjects for operator testing #208

appsforartists opened this issue Apr 25, 2017 · 0 comments

Comments

@appsforartists
Copy link
Member

appsforartists commented Apr 25, 2017

Our unit tests currently use a very simple MockObserver, which essentially turns an observer inside-out so its next method may be called by unit tests. Unfortunately, this presumes that there is only one observer per test, an assumption that fails for .velocity(pulse). Thus, we should use MotionSubjects for testing.

TODO

  • Create MotionSubject: export const MotionSubject = withMotionOperators(IndefiniteSubject)
  • Port all operator unit tests to use MotionSubject instead of createMockObserver()
  • Delete createMockObserver()

Blocked on #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant