Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in browser #92

Open
Svetomechc opened this issue Jan 29, 2019 · 5 comments
Open

Doesn't work in browser #92

Svetomechc opened this issue Jan 29, 2019 · 5 comments

Comments

@Svetomechc
Copy link

I'm trying to use this in an Angular 7 app, but it seems this is not possible?

@vitalets
Copy link

This lib is for Node.js.

@cjrsgu
Copy link

cjrsgu commented Mar 6, 2019

It doesn't work in browser because it uses cross origin requests. I made it work here google-translate-api-browser. It uses cors-anywhere

@vitalets
Copy link

vitalets commented Mar 6, 2019

It doesn't work in browser because it uses cross origin requests. I made it work here google-translate-api-browser. It uses cors-anywhere

I think you should definitely mention that all requests are proxied via http://cors-anywhere.herokuapp.com. If that app goes down or your users pass sensitive data for translation - it may have impact on you.

@rawr51919
Copy link

Ye. @cjvnjde, I carried over the additions and fixes that were added recently into vitalets' fork of this repo over to yours. Go ahead and take a look at that PR and see if things still work like they should over there with the new code in place.

@AidanWelch
Copy link

In case others are looking here is an up-to-date axios port: https://github.com/AidanWelch/google-translate-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants