Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OSD progress bar's completed section color configurable or solid white #2579

Open
scottjad opened this issue Dec 10, 2015 · 6 comments
Open
Labels
core:option-param-conf config, parameters, properties, options, shortcuts core:osd meta:feature-request

Comments

@scottjad
Copy link

On a white background, the default progress bar basically consists of a single black line separating watched from unwatched.

That doesn't really stand out as much as one might hope. It would be nice to have the completed and uncompleted sections be more distinctly colored.

The uncompleted section doesn't actually have a color, so I used to use osd-back-color="#77000000" to give it a gray color, which stood out nicely against the solid white of the completed section.

But sometime in the past year the progress bar's completed section started using what appears to be a non-transparent version of the back-color and now the difference between completed and uncompleted can be impossible to see on a white background.

I recommend:

  • User can set a color for the completed section of the progress bar.
  • If no color is set, use solid white not the back-color.
@ghost ghost added the meta:feature-request label Dec 10, 2015
@ghost
Copy link

ghost commented Dec 10, 2015

Wait, so this is essentially a "regression"?

@scottjad
Copy link
Author

I prefer the old behavior, yes. I don't know why the change was made though, maybe there was a really good reason. Or maybe it was unintentional as part of another change. A custom color only for the progress bar completed section wasn't previously possible, AFAIK.

@ChrisK2
Copy link
Member

ChrisK2 commented Dec 10, 2015

The current way the bar is build is the result of other requests to be able configure certain things ... I don't remember exactly anymore what that was but the current layout was the best we came up with to satisfy most requests.

@Akemi Akemi added core:osd core:option-param-conf config, parameters, properties, options, shortcuts labels Sep 20, 2019
@butterw
Copy link

butterw commented Dec 7, 2020

The progress bar isn't usable at all with any solid osd-back-color (ex: "#ff202830").
osd-back-color="#ff202830"
osd-color=0.878
osd-border-size=0.8

@butterw
Copy link

butterw commented Dec 8, 2020

The issue is also significantly worse than reported by the OP on a light video, when near opaque osd-back-color is used.
The bar is shown by default with chapters/seeking/show-progress/volume.

Please add a configuration parameter for osd bar-fill if necessary to fix this long-standing limitation/bug.

@butterw
Copy link

butterw commented Dec 4, 2023

There is still no osd-bar-color parameter to set the color of the fill of the osd-bar independently (ex: youtube shorts uses red for the osd progress bar). You'd also need an osd-bar-background parameter for it to look good though.

Some better than default settings (from reddit):
--no-osc
--osd-bar-align-y=1.0
--osd-bar-w=100
--osd-bar-h=0.3

with the latest dev build you also need: --osd-bar-border-size=0
if you need chapter markers, you could use something like:
--osd-bar-h=1.0
--osd-bar-border-size=0.25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:option-param-conf config, parameters, properties, options, shortcuts core:osd meta:feature-request
4 participants