Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade algoliasearch to v4 #35334

Open
iamsobanjaved opened this issue Aug 21, 2024 · 7 comments
Open

Upgrade algoliasearch to v4 #35334

iamsobanjaved opened this issue Aug 21, 2024 · 7 comments

Comments

@iamsobanjaved
Copy link
Contributor

Recently algoliasearch released the new major version v4 of its Python client and it has multiple breaking changes, which will impact one of the edX platform plugins. So we must make that plugin compatible with algoliasearch v4 before upgrading this package.

Changelog: https://algolia.com/doc/libraries/python/v4/upgrade/

@robrap
Copy link
Contributor

robrap commented Aug 21, 2024

This work should probably be moved to the website team. We can discuss when Jeremy returns, unless @spencertiberi wants to take care of ensuring this work gets ticketed by the other team. Additionally, we should point this ticket to any new tickets where applicable.

@iamsobanjaved
Copy link
Contributor Author

Yes, this issue is created for the constraint to be compatible with this work (#35055). This dependency was added for the learner_recommendations app which then was transformed into a private edX platform plugin (#33782), which Aperture now owns. So this will go to Aperture and we can remove this dependency from here and add in that private plugin.

@robrap
Copy link
Contributor

robrap commented Aug 21, 2024

Sounds good. Just making sure this makes it to an Aperture ticket then.

@jristau1984
Copy link
Contributor

@hurtstotouchfire - are you able to move this to Aperture's queue? Thanks!

@jristau1984
Copy link
Contributor

@hurtstotouchfire one more ping.

@kbuchanan-2u
Copy link

kbuchanan-2u commented Sep 9, 2024

FYI, I got a new github but haven't gotten around to fully transitioning access. Sorry about that. I'll probably be terrible about responding to pings on the new account as well though. 😅

@justinhynes can you get this into our backlog?

@justinhynes
Copy link
Contributor

All set, internal ticket is APER-3668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants