Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review .plain/.borderless buttons for passthrough #584

Open
keeshux opened this issue Sep 6, 2024 · 1 comment
Open

Review .plain/.borderless buttons for passthrough #584

keeshux opened this issue Sep 6, 2024 · 1 comment
Assignees
@keeshux
Labels
bug Something isn't working iOS Related to iOS app refactoring Improves software architecture

Comments

@keeshux
Copy link
Member

keeshux commented Sep 6, 2024 •
edited
Loading

They allow tap behind Menu on iOS, see #581.
@keeshux keeshux added the refactoring Improves software architecture label Sep 6, 2024
@keeshux keeshux added this to the v3 on TestFlight: 1. MVP milestone Sep 6, 2024
@keeshux keeshux added the iOS Related to iOS app label Sep 6, 2024
@keeshux keeshux self-assigned this Sep 6, 2024
@keeshux
Copy link
Member Author

keeshux commented Sep 6, 2024 •
edited
Loading

  • .plain
    • ThemeCopiableText
    • RevealingSecureField (no big deal)
  • .borderless
    • ConnectionButtons (InstalledProfileView)
    • ConnectionHandlerModifier (ProfileRowView → ProfileCardView)
    • ProfileInfoButton (ProfileRowView/InstalledProfileView)
@keeshux keeshux changed the title Review all .plain/.borderless buttons Sep 6, 2024
@keeshux keeshux added the bug Something isn't working label Sep 6, 2024
@keeshux keeshux removed this from the v3 on TestFlight: 1. MVP milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working iOS Related to iOS app refactoring Improves software architecture
1 participant
@keeshux