Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] sota-implementation requires nightly built #2401

Open
3 tasks done
jimdor opened this issue Aug 26, 2024 · 2 comments
Open
3 tasks done

[BUG] sota-implementation requires nightly built #2401

jimdor opened this issue Aug 26, 2024 · 2 comments
Assignees
@vmoens
Labels
bug Something isn't working

Comments

@jimdor
Copy link

jimdor commented Aug 26, 2024

Describe the bug

dqn_cartpole from sota-implementations/dqn doesn't working. Crashes with: ImportError: cannot import name 'Composite' from 'torchrl.data'

To Reproduce

Just run dqn_cartpole.py, it will call ulits_cartpole.py and then it will crash with ImportError

System info

Describe the characteristic of your environment:

  • The library was installed using pip
  • Python version = 3.9.19

Reason and Possible fixes

After some time i think rename Composite -> CompositeSpec in importing and in it's only one will fix this issue

Checklist

  • I have checked that there is no similar issue in the repo (required)
  • I have read the documentation (required)
  • I have provided a minimal working example to reproduce the bug (required)
@jimdor jimdor added the bug Something isn't working label Aug 26, 2024
@vmoens
Copy link
Contributor

vmoens commented Aug 26, 2024

This is due to a change in the specs names, try from v0.4.0

https://github.com/pytorch/rl/tree/v0.4.0
@vmoens vmoens changed the title [BUG] Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
8 participants
@vmoens @jimdor and others