Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify honggfuzz version in ci-fuzz #782

Conversation

valentinewallace
Copy link
Contributor

I've been consistently running into some version of honggfuzz dependency (0.5.45) and build command (0.5.49) versions do not match. This seems to fix it.

@TheBlueMatt
Copy link
Collaborator

I assume the issue is cargo cache, can we instead just call cargo update to make sure we're on the latest version?

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #782 (8f586a5) into main (25c9a37) will decrease coverage by 0.05%.
The diff coverage is 96.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   91.28%   91.22%   -0.06%     
==========================================
  Files          37       37              
  Lines       22847    22921      +74     
==========================================
+ Hits        20855    20910      +55     
- Misses       1992     2011      +19     
Impacted Files Coverage Δ
lightning/src/util/enforcing_trait_impls.rs 90.19% <80.76%> (-9.81%) ⬇️
lightning/src/chain/keysinterface.rs 93.47% <100.00%> (+0.17%) ⬆️
lightning/src/ln/chanmon_update_fail_tests.rs 97.56% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 95.13% <100.00%> (+<0.01%) ⬆️
lightning/src/ln/functional_tests.rs 96.93% <100.00%> (-0.15%) ⬇️
lightning/src/ln/onchaintx.rs 94.02% <100.00%> (ø)
lightning/src/util/test_utils.rs 84.78% <100.00%> (+1.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c9a37...89cc84a. Read the comment docs.

@valentinewallace
Copy link
Contributor Author

I assume the issue is cargo cache, can we instead just call cargo update to make sure we're on the latest version?

That worked. I went to add this to the README and saw it was already there, lol, so i think I just needed to RTFM.

So I think this actually doesn't make sense, because ci-fuzz is really just intended for CI, gonna close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants