Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dplyr warning when using tabyl #526

Open
larry77 opened this issue Feb 2, 2023 · 5 comments
Open

Dplyr warning when using tabyl #526

larry77 opened this issue Feb 2, 2023 · 5 comments

Comments

@larry77
Copy link

larry77 commented Feb 2, 2023

Hello,
I just want to report that the latest dplyr release gives a warning when I use the tabyl function from janitor.
Everything is documented here

tidyverse/dplyr#6679

but I think it is really a janitor rather than dplyr issue.

@billdenney
Copy link
Collaborator

Thanks for the issue report. This has been addressed in the development version, and it should be on CRAN soon.

@sfirke
Copy link
Owner

sfirke commented Feb 2, 2023

Hm this is not the error in adorn_totals() that I was expecting. And it looks like I can replicate this with the new janitor 2.2.0. I will reopen while I look into it. The warning message isn't too helpful on its own, I wonder if the tidyverse team will have any light to shed on it.

@sfirke sfirke reopened this Feb 2, 2023
@larry77
Copy link
Author

larry77 commented Feb 2, 2023

Hi,

And thanks for the quick reaction. After installing the development version of janitor, this warning is gone from my platform.

library(dplyr)
#> 
#> Attaching package: 'dplyr'
#> The following objects are masked from 'package:stats':
#> 
#>     filter, lag
#> The following objects are masked from 'package:base':
#> 
#>     intersect, setdiff, setequal, union
library(janitor)
#> 
#> Attaching package: 'janitor'
#> The following objects are masked from 'package:stats':
#> 
#>     chisq.test, fisher.test

df <- structure(list(member_state_3_letter_codes = c("AUT", "AUT", 
"AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT", 
"AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT", "AUT"
), procedure_name = c("General Block Exemption Regulation", "Notified Aid", 
"Notified Aid", "Notified Aid", "Notified Aid", "Notified Aid", 
"Notified Aid", "Notified Aid", "General Block Exemption Regulation", 
"General Block Exemption Regulation", "General Block Exemption Regulation", 
"General Block Exemption Regulation", "General Block Exemption Regulation", 
"General Block Exemption Regulation", "General Block Exemption Regulation", 
"General Block Exemption Regulation", "General Block Exemption Regulation", 
"General Block Exemption Regulation", "General Block Exemption Regulation", 
"Notified Aid")), row.names = c(NA, -20L), class = c("tbl_df", 
"tbl", "data.frame"))


df2 <- df|>tabyl(procedure_name)

df2
#>                      procedure_name  n percent
#>  General Block Exemption Regulation 12     0.6
#>                        Notified Aid  8     0.4

sessionInfo()
#> R version 4.2.2 (2022-10-31)
#> Platform: x86_64-pc-linux-gnu (64-bit)
#> Running under: Debian GNU/Linux 11 (bullseye)
#> 
#> Matrix products: default
#> BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.9.0
#> LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.9.0
#> 
#> locale:
#>  [1] LC_CTYPE=en_GB.UTF-8       LC_NUMERIC=C              
#>  [3] LC_TIME=en_GB.UTF-8        LC_COLLATE=en_GB.UTF-8    
#>  [5] LC_MONETARY=en_GB.UTF-8    LC_MESSAGES=en_GB.UTF-8   
#>  [7] LC_PAPER=en_GB.UTF-8       LC_NAME=C                 
#>  [9] LC_ADDRESS=C               LC_TELEPHONE=C            
#> [11] LC_MEASUREMENT=en_GB.UTF-8 LC_IDENTIFICATION=C       
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> other attached packages:
#> [1] janitor_2.2.0    dplyr_1.1.0.9000
#> 
#> loaded via a namespace (and not attached):
#>  [1] compiler_4.2.2    pillar_1.8.1      highr_0.10        R.methodsS3_1.8.2
#>  [5] R.utils_2.12.2    tools_4.2.2       digest_0.6.31     lubridate_1.9.1  
#>  [9] evaluate_0.19     lifecycle_1.0.3   tibble_3.1.8      R.cache_0.16.0   
#> [13] timechange_0.2.0  pkgconfig_2.0.3   rlang_1.0.6       reprex_2.0.2     
#> [17] cli_3.6.0         yaml_2.3.6        xfun_0.36         fastmap_1.1.0    
#> [21] withr_2.5.0       styler_1.9.0      stringr_1.5.0     knitr_1.41       
#> [25] generics_0.1.3    fs_1.5.2          vctrs_0.5.2       tidyselect_1.2.0 
#> [29] glue_1.6.2        snakecase_0.11.0  R6_2.5.1          fansi_1.0.4      
#> [33] rmarkdown_2.19    purrr_1.0.1       tidyr_1.3.0       magrittr_2.0.3   
#> [37] htmltools_0.5.4   utf8_1.2.3        stringi_1.7.12    R.oo_1.25.0

Created on 2023-02-02 with reprex v2.0.2

No idea why things are different on another platform.

@sfirke
Copy link
Owner

sfirke commented Feb 2, 2023

Interesting. Glad it's gone now. The warning I got from dplyr said it'll pop up only once every 8 hours, which is inconvenient for debugging. I'll stop thinking about this one for a while until I hear from others who are affected or if I hear from the dplyr team. And I'll leave it open to gather more info.

@larry77
Copy link
Author

larry77 commented Feb 2, 2023

True, but if you restart your R session the warning will pop up again without waiting for 6 hours if the problem is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants