Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain segment in memory on QuotaExceededError #1352

Open
joeyparrish opened this issue Mar 13, 2018 · 0 comments
Open

Retain segment in memory on QuotaExceededError #1352

joeyparrish opened this issue Mar 13, 2018 · 0 comments
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

When MediaSource throws QuotaExceededError, we reduce the buffering goal to try to avoid subsequent errors. But when MediaSource rejects this media segment, we don't retain it in memory. The pipeline is entirely ephemeral, and we end up downloading that segment again.

Ideally, we could retain the segment in StreamingEngine in memory until it has been accepted by MediaSourceEngine. This will depend on the same architecture changes needed for #880, in which StreamingEngine will need to be generally capable of retaining segments without MediaSource.

@joeyparrish joeyparrish added the type: enhancement New feature or request label Mar 13, 2018
@joeyparrish joeyparrish added this to the v2.5 milestone Mar 13, 2018
@joeyparrish joeyparrish modified the milestones: v2.5, Backlog Jul 9, 2018
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Sep 29, 2021
@avelad avelad modified the milestones: Backlog, v5.0 Apr 10, 2024
@avelad avelad assigned avelad and unassigned avelad Apr 10, 2024
@avelad avelad modified the milestones: v5.0, Backlog Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
2 participants