Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for ABR #1429

Open
joeyparrish opened this issue May 2, 2018 · 0 comments
Open

Test coverage for ABR #1429

joeyparrish opened this issue May 2, 2018 · 0 comments
Labels
priority: P3 Useful but not urgent type: code health A code health issue type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

Our existing integration tests disable ABR for predictability. We should build tests that cover ABR behavior by simulating network conditions on the client side.

Using the same StreamGenerator class we already use in integration tests, we can avoid unpredictable network conditions. The media data will be loaded into memory at the start of the test suite, and no actual network traffic will be necessary during playback.

That data is still loaded through NetworkingEngine, though, and the test suite can install response filters to force predictable throughput and latency levels that simulate various network conditions.

In that way, we could write test scenarios for ABR to demonstrate that we make appropriate choices and don't trigger a buffering event if it can be avoided.

@joeyparrish joeyparrish added type: enhancement New feature or request type: code health A code health issue labels May 2, 2018
@joeyparrish joeyparrish added this to the v2.6 milestone May 2, 2018
@vaage vaage modified the milestone: v2.6 Nov 26, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Sep 16, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@TheModMaker TheModMaker added the priority: P3 Useful but not urgent label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: code health A code health issue type: enhancement New feature or request
3 participants