Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider legacy Edge workaround in test/media/playhead_unit.js #1471

Open
theodab opened this issue Jun 22, 2018 · 1 comment
Open

Consider legacy Edge workaround in test/media/playhead_unit.js #1471

theodab opened this issue Jun 22, 2018 · 1 comment
Assignees
Labels
browser: Edge Issues affecting Microsoft Edge (any version) platform: Xbox Issues affecting Xbox priority: P3 Useful but not urgent type: code health A code health issue type: enhancement New feature or request
Milestone

Comments

@theodab
Copy link
Contributor

theodab commented Jun 22, 2018

In VideoWrapper.movePlayhead_, there is a workaround for a legacy Edge bug that causes the video wrapper to try to seek up to 11 times in a row until the seek works.
Technically, some of our playhead unit tests were triggering this workaround; however, since the workaround is based on setTimeout and the tests were synchronous, we simply ended the tests before the setTimeout resolved, and didn't notice.
We should probably adjust the tests to account for this workaround, instead of just technically avoiding it like we are now. This will improve the accuracy of the tests, and will also let us use jasmine.clock().tick() in those tests instead of jasmine.clock().setDate().

@theodab theodab added the type: code health A code health issue label Jun 22, 2018
@theodab theodab added this to the v2.6 milestone Jun 22, 2018
@joeyparrish
Copy link
Member

First, I think we should evaluate whether or not the workaround is still necessary. It would be ideal to be able to remove the hack completely instead of adjusting the tests.

@TheModMaker TheModMaker added the type: enhancement New feature or request label Jun 22, 2018
@vaage vaage modified the milestone: v2.6 Nov 26, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 12, 2020
@theodab theodab added browser: Edge Issues affecting Microsoft Edge (any version) priority: P3 Useful but not urgent labels Oct 2, 2021
@theodab theodab added the platform: Xbox Issues affecting Xbox label Apr 30, 2024
@theodab theodab changed the title Consider IE/Edge workaround in test/media/playhead_unit.js Apr 30, 2024
@theodab theodab changed the title Consider Legacy Edge workaround in test/media/playhead_unit.js Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser: Edge Issues affecting Microsoft Edge (any version) platform: Xbox Issues affecting Xbox priority: P3 Useful but not urgent type: code health A code health issue type: enhancement New feature or request
4 participants