Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using "Object" in annotations #1672

Open
joeyparrish opened this issue Nov 19, 2018 · 0 comments
Open

Stop using "Object" in annotations #1672

joeyparrish opened this issue Nov 19, 2018 · 0 comments
Labels
priority: P3 Useful but not urgent type: code health A code health issue
Milestone

Comments

@joeyparrish
Copy link
Member

joeyparrish commented Nov 19, 2018

There are several reasons we have used the "Object" type in our annotations in the past:

  1. For an open-ended type, such as in configure()
  2. As a Map or Set, since we didn't always have ES6 Maps & Sets available to us
  3. Because we didn't want to bother defining a type

Reason 1 may have to stick around. I'm not sure yet.

Reason 2 is no longer valid, and these should be converted to Maps or Sets.

Reason 3 was never valid, and this especially needs to be fixed.

@joeyparrish joeyparrish added the type: code health A code health issue label Nov 19, 2018
@joeyparrish joeyparrish added this to the v2.6 milestone Nov 19, 2018
@vaage vaage modified the milestone: v2.6 Nov 26, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 12, 2020
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: code health A code health issue
2 participants