Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visual layout tests to the UI lib #1675

Open
ismena opened this issue Nov 19, 2018 · 5 comments
Open

Add visual layout tests to the UI lib #1675

ismena opened this issue Nov 19, 2018 · 5 comments
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
Milestone
Backlog

Comments

@ismena
Copy link
Contributor

ismena commented Nov 19, 2018

There should be tests making sure everything looks nice in all of the supported browsers.
@ismena ismena added the component: UI The issue involves the Shaka Player UI label Nov 19, 2018
@joeyparrish joeyparrish changed the title Add cross-browser verification to the UI lib Nov 19, 2018
@TheModMaker TheModMaker added type: enhancement New feature or request type: code health A code health issue labels Nov 30, 2018
@TheModMaker TheModMaker added this to the Backlog milestone Nov 30, 2018
@joeyparrish joeyparrish removed their assignment Jul 10, 2019
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@aditmehta9
Copy link
Contributor

@ismena I am interested in performing cross-browser testing but I don't which platform I am supposed to use and do I have to test manually or automated. Your guidance will be helpful.
@ismena
Copy link
Contributor Author

ismena commented Mar 18, 2021

This is actually not up to date and has already been implemented. Sorry for the confusion!
@ismena ismena closed this as completed Mar 18, 2021
@aditmehta9
Copy link
Contributor

This is actually not up to date and has already been implemented. Sorry for the confusion!

Ok sir.
@ismena
Copy link
Contributor Author

ismena commented Mar 18, 2021 •
edited
Loading

Ok sir.

I honestly don't mind and kinda find this adorable, but just for the sake of representation and diversity awareness - I'm female! :) (So, a ma'am? Maybe? A miss? Just @ismena is fine though)
So is @michellezhuogg who you'll likely be working with on any gcos projects!

On a related note, turns out only have text rendering screenshot tests, not UI layout, but either way this is very closely tied to our internal (private) infrastructure and thus won't be a good project for anybody outside Google.
@joeyparrish joeyparrish reopened this Mar 18, 2021
@aditmehta9
Copy link
Contributor

Ok sir.

I honestly don't mind and kinda find this adorable, but just for the sake of representation and diversity awareness - I'm female! :) (So, a ma'am? Maybe? A miss? Just @ismena is fine though)
So is @michellezhuogg who you'll likely be working with on any gcos projects!

On a related note, turns out only have text rendering screenshot tests, not UI layout, but either way this is very closely tied to our internal (private) infrastructure and thus won't be a good project for anybody outside Google.

Yes ma'am.
@joeyparrish joeyparrish added priority: P2 Smaller impact or easy workaround and removed type: code health A code health issue labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround type: enhancement New feature or request
4 participants
@TheModMaker @ismena @joeyparrish @aditmehta9