Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I change the default Chromecast background? #4240

Closed
ghost opened this issue May 18, 2022 · 5 comments
Closed

How do I change the default Chromecast background? #4240

ghost opened this issue May 18, 2022 · 5 comments
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 18, 2022

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
3.1.6

Please ask your question
When using the default Cast Receiver ID, the Chromecast initially shows the default "Ready to try Shaka's Chromecast support?" Is it possible to add a custom background?
image

@ghost ghost added the type: question A question from the community label May 18, 2022
@theodab
Copy link
Contributor

theodab commented May 18, 2022

There's no built-in way to do it. The default cast receiver is meant to be a demo that shows how you can make your own receiver. It's not meant to be a production app, per-se.

I don't see why it would hurt to include an optional flag in the appData passed into the default receiver using shaka.cast.CastSender.setAppData, though. Like, an URL you can provide that will override the images provided in the CSS. The code changes would entirely be in the demo and the default cast receiver, rather than the library proper, so it'd be a fairly safe change.

@theodab theodab added type: enhancement New feature or request flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: good first issue This might be a relatively easy issue; good for new contributors component: demo page The issue is in the demo page; does not affect production applications priority: P4 Nice to have / wishful thinking and removed type: question A question from the community labels May 18, 2022
@github-actions github-actions bot added this to the Backlog milestone May 18, 2022
@avelad
Copy link
Member

avelad commented May 18, 2022

@theodab I'm not sure we want to support this, since we want to do #4214 in the future

@ghost
Copy link
Author

ghost commented May 18, 2022

I don't see why it would hurt to include an optional flag in the appData passed into the default receiver using shaka.cast.CastSender.setAppData, though. Like, an URL you can provide that will override the images provided in the CSS. The code changes would entirely be in the demo and the default cast receiver, rather than the library proper, so it'd be a fairly safe change.

@theodab I would like to remove the "Ready to try..." text as well. Basically, I want to display only a specific image (or custom HTML file) in its place

@joeyparrish
Copy link
Member

I think this team should focus on #4214 and drive users toward styled media receivers once they are more capable and better integrated with Shaka.

In the meantime, you can make whatever changes you want to our demo receiver, or build your own on top of our receiver APIs. Either way, you'd be publishing a custom receiver.

@joeyparrish joeyparrish added status: will not implement The team chooses not to implement this enhancement and removed flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this flag: good first issue This might be a relatively easy issue; good for new contributors labels May 18, 2022
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 24, 2022
@avelad avelad removed this from the Backlog milestone May 24, 2022
@github-actions github-actions bot added this to the Backlog milestone May 24, 2022
@avelad avelad removed this from the Backlog milestone May 25, 2022
@github-actions github-actions bot added this to the Backlog milestone May 25, 2022
@github-actions
Copy link
Contributor

Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including @shaka-bot reopen in a comment.

@github-actions github-actions bot removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label May 31, 2022
@avelad avelad removed this from the Backlog milestone May 31, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: demo page The issue is in the demo page; does not affect production applications priority: P4 Nice to have / wishful thinking status: archived Archived and locked; will not be updated status: will not implement The team chooses not to implement this enhancement type: enhancement New feature or request
3 participants