Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DASH): update period as part of configuration #6419

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat(DASH): update period as part of configuration #6419

merged 5 commits into from
Apr 9, 2024

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Apr 9, 2024 •
edited by avelad
Loading

Closes #6418
avelad
avelad requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@avelad avelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the new config in the Demo.
externs/shaka/player.js Outdated Show resolved Hide resolved
lib/util/player_configuration.js Outdated Show resolved Hide resolved
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent component: DASH The issue involves the MPEG DASH manifest format labels Apr 9, 2024
@avelad avelad added this to the v5.0 milestone Apr 9, 2024
avelad
avelad reviewed Apr 9, 2024
View reviewed changes
lib/dash/dash_parser.js Outdated Show resolved Hide resolved
@shaka-bot
Copy link
Collaborator

shaka-bot commented Apr 9, 2024 •
edited
Loading

Incremental code coverage: 85.00%
@Iragne
Copy link
Contributor Author

Iragne commented Apr 9, 2024

@avelad just added the config demo
@Iragne Iragne requested a review from avelad April 9, 2024 12:01
@avelad avelad requested a review from theodab April 9, 2024 12:10
@avelad avelad merged commit bdabddc into shaka-project:main Apr 9, 2024
17 of 18 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 9, 2024
Merged
@Iragne Iragne deleted the feat/dash-update-period-configuration branch April 9, 2024 12:55
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 8, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: DASH The issue involves the MPEG DASH manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
3 participants
@Iragne @shaka-bot @avelad