Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a new setting to allow remove based on channels count #6600

Merged
merged 2 commits into from
May 14, 2024
Merged

feat: Add a new setting to allow remove based on channels count #6600

merged 2 commits into from
May 14, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented May 13, 2024

Close #6491
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels May 13, 2024
@avelad avelad added this to the v4.9 milestone May 13, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%
theodab
theodab requested changes May 14, 2024
View reviewed changes
lib/util/stream_utils.js Outdated
@@ -299,6 +299,16 @@ shaka.util.StreamUtils = class {
}
}

// |variant.audio.frameRate| can be undefined, which breaks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say "variant.audio.channelsCount"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!
@avelad avelad requested a review from theodab May 14, 2024 07:39
@avelad avelad merged commit 0206e5a into shaka-project:main May 14, 2024
16 checks passed
@shaka-bot shaka-bot mentioned this pull request May 14, 2024
Merged
@avelad avelad deleted the channelscount-restrictions branch May 14, 2024 08:28
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 13, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
3 participants
@avelad @shaka-bot @theodab