Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tizen): Adding gapPadding to gap manager to solve Tizen issue #7331

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

Iragne
Copy link
Contributor

@Iragne Iragne commented Sep 17, 2024

Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen

Fixes #7124

Default value for Tizen set to 2 and can be configurable 
Solving issue associated to gapManager not able to pass the GAP on Tizen
@avelad avelad changed the title feat(Tizen):Adding gapPadding to gap manager to solve Tizen issue Sep 17, 2024
@avelad avelad changed the title feat(Tizen): Adding gapPadding to gap manager to solve Tizen issue Sep 17, 2024
@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: Tizen Issues affecting Tizen labels Sep 17, 2024
@avelad avelad added this to the v4.12 milestone Sep 17, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 62.50%

@avelad
Copy link
Member

avelad commented Sep 17, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=7331
@Iragne
Copy link
Contributor Author

Iragne commented Sep 17, 2024

I should correct unit test no @avelad but how i can validate for Tizen not sure to know that

@Iragne
Copy link
Contributor Author

Iragne commented Sep 18, 2024

still tuning with unit test

@avelad avelad merged commit 330e487 into shaka-project:main Sep 18, 2024
28 of 30 checks passed
avelad pushed a commit that referenced this pull request Sep 18, 2024
)

Default value for Tizen set to 2 and can be configurable Solving issue
associated to gapManager not able to pass the GAP on Tizen

Fixes #7124
avelad pushed a commit that referenced this pull request Sep 18, 2024
)

Default value for Tizen set to 2 and can be configurable Solving issue
associated to gapManager not able to pass the GAP on Tizen

Fixes #7124
joeyparrish pushed a commit that referenced this pull request Sep 18, 2024
)

Default value for Tizen set to 2 and can be configurable Solving issue
associated to gapManager not able to pass the GAP on Tizen

Fixes #7124

Backported to v4.9.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Tizen Issues affecting Tizen priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
3 participants