-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tizen): Adding gapPadding to gap manager to solve Tizen issue #7331
Merged
avelad
merged 8 commits into
shaka-project:main
from
Iragne:feat/Tizen-gap-jump-configuration
Sep 18, 2024
Merged
fix(Tizen): Adding gapPadding to gap manager to solve Tizen issue #7331
avelad
merged 8 commits into
shaka-project:main
from
Iragne:feat/Tizen-gap-jump-configuration
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen
avelad
changed the title
feat(Tizen):Adding gapPadding to gap manager to solve Tizen issue
Sep 17, 2024
avelad
changed the title
feat(Tizen): Adding gapPadding to gap manager to solve Tizen issue
Sep 17, 2024
avelad
added
type: bug
Something isn't working correctly
priority: P1
Big impact or workaround impractical; resolve before feature release
platform: Tizen
Issues affecting Tizen
labels
Sep 17, 2024
Incremental code coverage: 62.50% |
@shaka-bot test |
@avelad: Lab tests started with arguments:
|
I should correct unit test no @avelad but how i can validate for Tizen not sure to know that |
still tuning with unit test |
avelad
approved these changes
Sep 18, 2024
avelad
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen Fixes #7124
avelad
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen Fixes #7124
joeyparrish
pushed a commit
that referenced
this pull request
Sep 18, 2024
) Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen Fixes #7124 Backported to v4.9.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform: Tizen
Issues affecting Tizen
priority: P1
Big impact or workaround impractical; resolve before feature release
type: bug
Something isn't working correctly
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default value for Tizen set to 2 and can be configurable Solving issue associated to gapManager not able to pass the GAP on Tizen
Fixes #7124