Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.py --force needed when customizations change #759

Open
joeyparrish opened this issue Apr 25, 2017 · 1 comment
Open

build.py --force needed when customizations change #759

joeyparrish opened this issue Apr 25, 2017 · 1 comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
Milestone

Comments

@joeyparrish
Copy link
Member

When customizing the build as detailed in the Plugins and Customizing the Build Tutorial, if you change the build parameters like so:

# Build without polyfills:
python build/build.py +@complete -@polyfill
# Build without polyfills or text parsers:
python build/build.py +@complete -@polyfill -@text

The second build will not happen without --force. Instead, you get this message:

Compiling the library...
No changes detected, not building.  Use --force to override.

Ideally, we could detect that the build parameters have changed and rebuild anyway.

@joeyparrish joeyparrish added this to the Backlog milestone Apr 25, 2017
@joeyparrish joeyparrish added the type: enhancement New feature or request label Apr 25, 2017
@joeyparrish
Copy link
Member Author

Design from @TheModMaker:

  1. Next to each build, output a manifest of the input JS files that went into that build.
  2. When asked to build, check for this manifest and compare it to the list of inputs files for this build.
  3. If the list has changed, rebuild regardless of changes to the source files.
@joeyparrish joeyparrish modified the milestones: Backlog, v2.4.0 Oct 8, 2017
@joeyparrish joeyparrish modified the milestones: v2.4.0, Backlog Dec 4, 2017
@joeyparrish joeyparrish modified the milestones: Backlog, Backlog 2 Jan 28, 2020
@joeyparrish joeyparrish added the priority: P3 Useful but not urgent label Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P3 Useful but not urgent type: enhancement New feature or request
1 participant