Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neither dependency works on 2.4.0 #95

Open
Beanow opened this issue Jun 11, 2017 · 7 comments
Open

Neither dependency works on 2.4.0 #95

Beanow opened this issue Jun 11, 2017 · 7 comments

Comments

@Beanow
Copy link

Beanow commented Jun 11, 2017

When installing giflossy it says:

Could not find gifsicle. Is it installed?

More info: https://github.com/vvo/gifify#requirements

When installing gifsicle it say:

gifsicle needs lossy

Using cli interface and global installs.

@Beanow
Copy link
Author

Beanow commented Jun 11, 2017

As a workaround I used this in linux to fake the name.

sudo ln -s /usr/local/lib/node_modules/giflossy/cli.js /usr/local/bin/gifsicle
@vvo
Copy link
Owner

vvo commented Jun 13, 2017

I have no idea of the issue.

@Beanow
Copy link
Author

Beanow commented Jun 13, 2017

The problem is you're using spawn to detect the dependency. So if gifsicle is not an executable that has a --lossy param in it's usage string, it will give either error. Because npm install -g giflossy does not give you a gifsicle executable, but giflossy you can't use it as a drop-in replacement. You would need to detect which of the two is available.

@vvo
Copy link
Owner

vvo commented Jun 13, 2017

I think we are fine asking for a non-npm installation of giflossy. Also I have high hopes lossy will be part of gifsicle, soon.

If you want to add that check, accepting PRs still

@nicolas-raoul
Copy link

Still no giflossy in Ubuntu 2019.04's gifsicle.

@jtoy
Copy link

jtoy commented Apr 5, 2020

just ran into same thing

@Sawiq
Copy link

Sawiq commented Apr 15, 2020

Still no giflossy in Ubuntu 2019.04's gifsicle.

Same in Linux Mint 19.3 - gifsicle version 1.91, while current-one is 1.92. Maybe it is worth to ping debian package maintainer? nwm, debian buster has got version 1.92, so next iteration of debian-based distros will contain it by default.

The problem is you're using spawn to detect the dependency. So if gifsicle is not an executable that has a --lossy param in it's usage string, it will give either error. Because npm install -g giflossy does not give you a gifsicle executable, but giflossy you can't use it as a drop-in replacement. You would need to detect which of the two is available.

After installation of giflossy via npm globally I have got gifsicle soft link. If there is no gifsicle executable Beanow solution will work for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants