Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many valueParseError since Marc 16 2019 in w3c/crawl.json #31

Closed
abhishiv opened this issue Mar 20, 2019 · 2 comments
Closed

Too many valueParseError since Marc 16 2019 in w3c/crawl.json #31

abhishiv opened this issue Mar 20, 2019 · 2 comments

Comments

@abhishiv
Copy link

Hey guys

Many thanks for publishing this!

Just notice that there are too many valueParseError since Marc 16 2019. They seem to be because of some encoding issue upstream.

Here's an example

          "<final-bg-layer>": {
            "value": "<‘background-color’> || <bg-image> || <bg-position> [ / <bg-size> ]? || <repeat-style> || <attachment> || <box> || <box>",
            "valueParseError": "Unrecognized token <‘background-color’>"
          },

https://github.com/tidoust/reffy-reports/blob/19a80a9de50cb62ad33f3987c63198d34bf17c15/w3c/crawl.json

@abhishiv abhishiv changed the title Too any valueParseError since Marc 16 2019 in w3c/crawl.json Mar 20, 2019
@tidoust
Copy link
Member

tidoust commented Mar 22, 2019

Hi @abhishiv,

I do not know what changes may have happened on March 16 2019, but these errors are, I believe, due to the fact that Reffy does not expect curly quotes in the definitions because the grammar does not seem to allow for them, see point 4. in w3c/csswg-drafts#2921

Given that more and more specs seem to be using curly quotes, the CSS grammar parser should be updated in Reffy to support them.

@tidoust
Copy link
Member

tidoust commented Mar 27, 2019

Hack implemented and proper support for curly quotes now tracked in w3c/reffy#148

The errors should disappear next time the crawler runs (in about a day or so). Closing this issue accordingly.

@tidoust tidoust closed this as completed Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants