Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] - Widgets enable script installs Edge despite declining #1091

Closed
coffandro opened this issue Apr 27, 2024 · 5 comments
Closed

[BUG] - Widgets enable script installs Edge despite declining #1091

coffandro opened this issue Apr 27, 2024 · 5 comments
Labels
bug Something isn't working, let’s fix that fixed next release Where next release will have the issue fixed workaround avaliable Where a temporary workaround/fix is available for an issue

Comments

@coffandro
Copy link

Description

The widget enable script installs edge despite being declined

Steps to reproduce

  1. Open the Atlas folder
  2. Run the widget enable script
  3. Decline installing edge (pres N)

Expected behavior

The script exists without an issue

Actual behavior

The script goes ahead and installs edge

Atlas Edition

Atlas for Windows 11 23H2

Desktop information

  • Thinkpad p50
  • Xeon E3 1505M
  • 48gb ram
  • Quadro M2000M
  • three drives, 4XX NVME (with windows on a 256gb partition), 256 NVME, 2TB SATA
  • Atlas v 0.4.0

Additional content

Running Atlas v0.4.0
@coffandro coffandro added the bug Something isn't working, let’s fix that label Apr 27, 2024
@Ast3risk-ops
Copy link

Pretty sure edge is required for the widgets (https://docs.atlasos.net/getting-started/post-installation/atlas-folder/general-configuration/#widgets-news-and-interests) but I think we should hook up a "no" answer to closing the script.
@coffandro
Copy link
Author

Forgot a screenshot but there already is a no, it dosent work thoughIMG_20240427_210020.jpg
@he3als he3als added the planned To be done in future. label May 7, 2024
@he3als he3als changed the title Widgets enable script installs edge despite declining May 27, 2024
he3als added a commit that referenced this issue May 30, 2024
@he3als
fix(edgeCheck): deny option (#1091)
e4e9a1a
@Xyueta
Copy link
Member

Xyueta commented May 31, 2024

This has been fixed in e4e9a1a, and will be available in the next release.
Thanks.
@Xyueta Xyueta closed this as completed May 31, 2024
@he3als
Copy link
Contributor

he3als commented Jun 1, 2024

I'm going to re-open this as I think it's best to keep issues open until there's a new release for transparency with users.
@he3als he3als reopened this Jun 1, 2024
@he3als he3als added fixed next release Where next release will have the issue fixed and removed planned To be done in future. labels Jun 1, 2024
@he3als he3als added the workaround avaliable Where a temporary workaround/fix is available for an issue label Jun 13, 2024
@he3als
Copy link
Contributor

he3als commented Oct 9, 2024

Fixed in release v0.4.1. See the release for more info on what v0.4 users can do.
@he3als he3als closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, let’s fix that fixed next release Where next release will have the issue fixed workaround avaliable Where a temporary workaround/fix is available for an issue
4 participants
@he3als @coffandro @Ast3risk-ops @Xyueta