Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting dashboard: Fix sites thumbnail margin #94510

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

DustyReagan
Copy link
Member

@DustyReagan DustyReagan commented Sep 12, 2024

Related to #94202

Proposed Changes

  • Removes extra margin on /sites thumbnails.
Before After
Screenshot 2024-09-12 at 4 00 19 PM Screenshot 2024-09-12 at 4 00 29 PM

Why are these changes being made?

  • Improve aesthetics and readability.

Testing Instructions

  • Use Calypso Live
  • Go to /sites and ensure the site list and thumbnails look good in various widths.
  • Try searching and filtering with different criteria to try and break the layout

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
@DustyReagan DustyReagan marked this pull request as ready for review September 12, 2024 21:04
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes removed 📉 [gzipped])

name                parsed_size           gzip_size
staging-site             -109 B  (-0.0%)      -31 B  (-0.0%)
sites-dashboard          -109 B  (-0.0%)      -31 B  (-0.0%)
site-performance         -109 B  (-0.0%)      -31 B  (-0.0%)
site-monitoring          -109 B  (-0.0%)      -31 B  (-0.0%)
site-logs                -109 B  (-0.0%)      -31 B  (-0.0%)
hosting-features         -109 B  (-0.0%)      -31 B  (-0.0%)
hosting                  -109 B  (-0.0%)      -31 B  (-0.0%)
github-deployments       -109 B  (-0.0%)      -31 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DustyReagan DustyReagan changed the title Fix sites thumbnail padding Sep 12, 2024
@DustyReagan DustyReagan requested a review from a team September 12, 2024 21:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 12, 2024
@DustyReagan DustyReagan self-assigned this Sep 12, 2024
Copy link
Member

@allilevine allilevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I tested at different screen widths and didn't see any issues. It looks like we originally added the margin as part of a thumbnail flickering fix, but I'm not seeing flickering without it.

@DustyReagan DustyReagan merged commit 4eb2a10 into trunk Sep 13, 2024
19 checks passed
@DustyReagan DustyReagan deleted the fix/sites-thumbnail-padding branch September 13, 2024 18:27
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@DustyReagan DustyReagan linked an issue Sep 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants