Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hosting dashboard: clean up Staging Site tab #94535

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

fushar
Copy link
Contributor

@fushar fushar commented Sep 13, 2024

Part of:

Proposed Changes

This PR refactors the code for the hosting dashboard's Staging Site tab, by moving them under client/hosting/staging-site/ directory.

Why are these changes being made?

Consistency and to avoid future confusion.

Testing Instructions

  1. Go to /sites.
  2. Select an Atomic site.
  3. Click the Staging Site tab.
  4. Smoke test and verify that the feature still works.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?
@fushar fushar self-assigned this Sep 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~3 bytes removed 📉 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +16 B  (+0.0%)       -2 B  (-0.0%)
entry-main           +16 B  (+0.0%)       -2 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~52 bytes added 📈 [gzipped])

name                parsed_size           gzip_size
staging-site             +177 B  (+0.0%)      -20 B  (-0.0%)
activity                  -32 B  (-0.0%)      +72 B  (+0.0%)
sites-dashboard           -16 B  (-0.0%)       -5 B  (-0.0%)
site-performance          -16 B  (-0.0%)       -5 B  (-0.0%)
site-monitoring           -16 B  (-0.0%)       -5 B  (-0.0%)
site-logs                 -16 B  (-0.0%)       -5 B  (-0.0%)
hosting-features          -16 B  (-0.0%)       -5 B  (-0.0%)
hosting                   -16 B  (-0.0%)       -5 B  (-0.0%)
github-deployments        -16 B  (-0.0%)       -5 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug refactor-staging-site-tab on your sandbox.

@fushar fushar requested a review from a team September 13, 2024 12:45
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
@fushar fushar requested review from a team and nightnei and removed request for a team September 13, 2024 12:45
@zaguiini zaguiini requested review from a team and removed request for a team September 13, 2024 12:46
Copy link
Contributor

@nightnei nightnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as previously 👍
Screenshot 2024-09-13 at 14 34 36
Screenshot 2024-09-13 at 14 34 52
Screenshot 2024-09-13 at 14 36 41

@fushar fushar merged commit 2859fe7 into trunk Sep 13, 2024
17 checks passed
@fushar fushar deleted the refactor-staging-site-tab branch September 13, 2024 13:51
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants