-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domains step: Improve domain title spacing on smaller screens #94550
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~22 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~22 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
@JanaMW27 or @nuriapenya would you be interested in taking a look at this one? You can easily do that with the live link and following the testing steps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying with a long domain name I now see it like this. Maybe 3 rows is too much? Max length of the domain in the input is 60 characters, can we have it in 2 rows? And the price should be in line with the domain name, with the offer copy in line with the |
I think setting up a max width for the domain and then domain name to other lines is a good logic to put in place to cover this edge cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it is working great! 👏
Related to #94426
Fixes #94426
Proposed Changes
This PR addresses the issue by repositioning the 'deal' badges above the title and ensuring that overly long titles are automatically broken into multiple lines for better readability and layout.
Issue
Fix
Why are these changes being made?
Testing Instructions
Navigate to any flow (e.g., /setup/onboarding/domains) and proceed to the domains step.
Select an excessively long domain name and verify that the layout remains intact (compare it with the production version).
Ensure the domain grid matches the provided screenshots.
Compare it with the /start/onboarding flow and confirm that the horizontal scroll issue has been resolved, especially on mobile or smaller screens.