Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains step: Improve domain title spacing on smaller screens #94550

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

renancarvalho
Copy link
Contributor

@renancarvalho renancarvalho commented Sep 13, 2024

Related to #94426
Fixes #94426

Proposed Changes

  • There are spacing issues when users choose excessively long domain names or titles. This affects both mobile and desktop views, with the main problem being the content growing too large to fit properly.

This PR addresses the issue by repositioning the 'deal' badges above the title and ensuring that overly long titles are automatically broken into multiple lines for better readability and layout.

Issue
image

Fix
image

Why are these changes being made?

  • Fixes this layout issue
image

Testing Instructions

  • Navigate to any flow (e.g., /setup/onboarding/domains) and proceed to the domains step.

  • Select an excessively long domain name and verify that the layout remains intact (compare it with the production version).

  • Ensure the domain grid matches the provided screenshots.

  • Compare it with the /start/onboarding flow and confirm that the horizontal scroll issue has been resolved, especially on mobile or smaller screens.

@renancarvalho renancarvalho self-assigned this Sep 13, 2024
@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~22 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
videopress-flow            +148 B  (+0.0%)      +22 B  (+0.0%)
update-design-flow         +148 B  (+0.0%)      +22 B  (+0.0%)
sensei-flow                +148 B  (+0.0%)      +22 B  (+0.0%)
link-in-bio-tld-flow       +148 B  (+0.0%)      +22 B  (+0.0%)
domains                    +148 B  (+0.0%)      +22 B  (+0.0%)
copy-site-flow             +148 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~22 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
async-load-signup-steps-domains       +148 B  (+0.0%)      +22 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented Sep 13, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/domains_mobile_layout on your sandbox.

@renancarvalho renancarvalho changed the title Domains step: Improve title spacing on smaller screens Sep 13, 2024
@renancarvalho renancarvalho requested a review from a team September 16, 2024 13:30
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 16, 2024
@renancarvalho renancarvalho marked this pull request as ready for review September 16, 2024 13:30
@renancarvalho renancarvalho requested a review from a team as a code owner September 16, 2024 13:30
@renancarvalho
Copy link
Contributor Author

@JanaMW27 or @nuriapenya would you be interested in taking a look at this one? You can easily do that with the live link and following the testing steps.
🙇

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

In the en version I see the sale text on two lines

image

That is probably breaking the design (as the price should be in line with the domain)

@renancarvalho
Copy link
Contributor Author

Thanks for working on this!

In the en version I see the sale text on two lines

image

That is probably breaking the design (as the price should be in line with the domain)

Addressed. Thank you!

@escapemanuele
Copy link
Contributor

Trying with a long domain name I now see it like this. Maybe 3 rows is too much?

image

Max length of the domain in the input is 60 characters, can we have it in 2 rows?

And the price should be in line with the domain name, with the offer copy in line with the Sale text.

@JanaMW27
Copy link

I think setting up a max width for the domain and then domain name to other lines is a good logic to put in place to cover this edge cases.

Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stepper now works great!

image

On /start there is some visual error though

image
Copy link
Contributor

@escapemanuele escapemanuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is working great! 👏

@renancarvalho renancarvalho merged commit abc9007 into trunk Sep 24, 2024
11 checks passed
@renancarvalho renancarvalho deleted the fix/domains_mobile_layout branch September 24, 2024 11:45
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 24, 2024
@renancarvalho renancarvalho restored the fix/domains_mobile_layout branch September 24, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants